Skip to content

Fix ./kafka-console-consumer.sh cmd line#337

Merged
wtrocki merged 1 commit intomainfrom
b1zzu-patch-1
Oct 11, 2021
Merged

Fix ./kafka-console-consumer.sh cmd line#337
wtrocki merged 1 commit intomainfrom
b1zzu-patch-1

Conversation

@b1zzu
Copy link
Collaborator

@b1zzu b1zzu commented Oct 11, 2021

Tested with Kafka 2.8.1 and the correct option is:

--consumer.config <String: config file>  Consumer config properties file. Note  
                                           that [consumer-property] takes       
                                           precedence over this config.    

Tested with Kafka 2.8.1 and the correct option is:
```
--consumer.config <String: config file>  Consumer config properties file. Note  
                                           that [consumer-property] takes       
                                           precedence over this config.    
```
@b1zzu b1zzu requested a review from PaulRMellor October 11, 2021 12:23
@wtrocki
Copy link
Collaborator

wtrocki commented Oct 11, 2021

This works and it looked like original instruction never worked (so this is not version regression) that we were so worried in terms of bin scripts.

@wtrocki wtrocki merged commit 0228081 into main Oct 11, 2021
@wtrocki wtrocki deleted the b1zzu-patch-1 branch October 11, 2021 14:00
smccarthy-ie pushed a commit to smccarthy-ie/app-services-guides that referenced this pull request Oct 15, 2021
Tested with Kafka 2.8.1 and the correct option is:
```
--consumer.config <String: config file>  Consumer config properties file. Note  
                                           that [consumer-property] takes       
                                           precedence over this config.    
```
smccarthy-ie added a commit that referenced this pull request Oct 15, 2021
* clean up draft of service registry quarkus quick start from bilgin

* update section IDs to fix quick start build errors, minor edits

* add changes to simplify code example in PR 327

* add final step to view generated schemas

* clarify separate consumer and producer processes

* pick up new attributes

* adding technical review feedback from carles and wojciech

* adding technical review feedback from carles and wojciech

* add OAUTH_SERVER_URL and OAUTH_REALM env vars required for now until quarkus is updated

* add correct SR icon, QE and peer review feedback

* regen attributes for new guides

* regen attributes for new cli guides

* Simplify registry quickstart (#327)

* Service registry RHOAS CLI (#324)

* docs: initial version of the guide

* fix: restructure tutorial content for better alignment for RHOAS CLI

* docs: service registry cli guide

Signed-off-by: prmellor <[email protected]>

* docs: service registry cli guide

Signed-off-by: prmellor <[email protected]>

* fix: remove confusing sentence

Co-authored-by: PaulRMellor <[email protected]>

* docs: add abstract to procedures

Signed-off-by: prmellor <[email protected]>

* fix: build issue

* docs: service registry instance without defaults

Signed-off-by: prmellor <[email protected]>

* fix: add mixxing version from consumer config

* docs: remove angle brackets from example

Signed-off-by: prmellor <[email protected]>

* docs: change keys

Signed-off-by: prmellor <[email protected]>

* fix: another duplicated key

* Update rhoas-cli-kafka/README.adoc

* Update rhoas-cli-service-registry/README.adoc

Co-authored-by: PaulRMellor <[email protected]>

* fix: build issue

* docs: review edits BI

Signed-off-by: prmellor <[email protected]>

* docs: review edits WT for name command

Signed-off-by: prmellor <[email protected]>

Co-authored-by: Wojciech Trocki <[email protected]>

* docs: updated readme with new CLI doc (#329)

Signed-off-by: prmellor <[email protected]>

* docs: cli guide mod doc fix (#330)

Signed-off-by: prmellor <[email protected]>

* Add basic metrics section in getting started QS. (#332)

* Add basic metrics section in getting started QS.

* SME review from Duncan

* Peer tweaks

* docs: fix links in CLI guides (#334)

* docs: fix links in CLI guides

Signed-off-by: prmellor <[email protected]>

* cli command updates

Signed-off-by: prmellor <[email protected]>

* review edits RK

Signed-off-by: prmellor <[email protected]>

* return wget to step

Signed-off-by: prmellor <[email protected]>

* Add access mgmt content. (#325)

* fix: ./kafka-console-consumer.sh cmd line (#337)

Tested with Kafka 2.8.1 and the correct option is:
```
--consumer.config <String: config file>  Consumer config properties file. Note  
                                           that [consumer-property] takes       
                                           precedence over this config.    
```

* Remove name from service account commands (#336)

* Rethinking metrics approach (#339)

* Rethinking metrics approach

* Tweak metrics section

* John feedback

* Added missing dash to kafka-console-consumer command. (#335)

* Fix the pom.xml files for quarkus-service-registry-quickstart (#343)

* Update the url for Service Registry core REST API Reference and Kafka Service Fleet Manager API Reference (#341)

* Add placeholder values registry quickstart (#333)

* Check installation and version of rhoas CLI on Windows (#338)

* fix: add kafka access management for rhoas cli (#342)

* fix: add kafka acl commands

* fix: add note about cli reference doc

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: PaulRMellor <[email protected]>

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: Ramakrishna Pattnaik <[email protected]>

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: PaulRMellor <[email protected]>

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: PaulRMellor <[email protected]>

* Apply suggestions from code review

Co-authored-by: PaulRMellor <[email protected]>

* Update README.adoc

* fix: add acl bullet

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: PaulRMellor <[email protected]>

* Update rhoas-cli-kafka/README.adoc

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: Ramakrishna Pattnaik <[email protected]>

* Update rhoas-cli-kafka/README.adoc

* Update rhoas-cli-kafka/README.adoc

Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: Ramakrishna Pattnaik <[email protected]>

* Add missing links to getting started (#347)

* rebase for recently added new guides

Co-authored-by: Carles Arnal <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Co-authored-by: Wojciech Trocki <[email protected]>
Co-authored-by: Stetson Robinson <[email protected]>
Co-authored-by: Davide Bizzarri <[email protected]>
Co-authored-by: Enda <[email protected]>
Co-authored-by: Duncan Doyle <[email protected]>
Co-authored-by: Eric Wittmann <[email protected]>
Co-authored-by: HemaHG <[email protected]>
Co-authored-by: Carles Arnal <[email protected]>
Co-authored-by: rkubis <[email protected]>
Co-authored-by: Ramakrishna Pattnaik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants